Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): removing spaces from logger #3334

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

marceloverdijk
Copy link
Contributor

@marceloverdijk marceloverdijk commented Aug 29, 2024

Fixes #3328

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yusukebe yusukebe changed the title Fix for #3328 removing spaces from logger fix(logger): removing spaces from logger Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (18f937d) to head (8001e15).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3334   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files         151      151           
  Lines        9166     9166           
  Branches     2726     2809   +83     
=======================================
  Hits         8778     8778           
  Misses        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@marceloverdijk

Thank you! Let's go with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hono/logger has annoying spaces when using a custom PrintFunc
2 participants